[web] Implement danger zone UI
ClosedPublic
Actions

Authored by tomek on May 20 2022, 9:39 AM.

Details

Reviewers

Commits

rCOMMe6da88fd7513: [web] Implement danger zone UI

Summary

Add all the components to the page. The design https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A87631 doesn't specify the copy below the button, but I think it might be a good idea to have a warning there - the same we currently have in delete tab of account settings.

Depends on D4094

Test Plan

Open http://localhost/comm/settings/danger-zone/ and check if it is displayed correctly.

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

tomek requested review of this revision.May 20 2022, 9:46 AM

atul added inline comments.

web/settings/danger-zone.react.js
13 ↗	(On Diff #12985)	Pretty sure this is a placeholder function since `onClick` is a required `prop` of the `Button` component, and will be replaced w/ a memoized function when it's replaced?

This revision is now accepted and ready to land.May 20 2022, 11:25 AM

web/settings/danger-zone.react.js
13 ↗	(On Diff #12985)	Exactly, that's the plan. Our `Button` doesn't allow skipping this prop, which is ok on one side as it protects us against forgetting to put the value, but doesn't make creating new UIs easier.