Page MenuHomePhabricator

[CI] Get rid of `touch` JSON commands in CI
ClosedPublic

Authored by atul on May 24 2022, 6:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 7:26 PM
Unknown Object (File)
Fri, Oct 18, 4:52 AM
Unknown Object (File)
Mon, Oct 14, 2:03 PM
Unknown Object (File)
Sat, Oct 12, 2:46 AM
Unknown Object (File)
Fri, Oct 11, 11:04 PM
Unknown Object (File)
Sat, Oct 5, 1:42 AM
Unknown Object (File)
Sat, Oct 5, 1:42 AM
Unknown Object (File)
Sat, Oct 5, 1:42 AM

Details

Summary

Linear Issue: https://linear.app/comm/issue/ENG-1190/get-rid-of-touch-json-commands-in-ci

We were previously creating empty JSON files via the touch command to appease flow in the ESLint/Flow/Test workflows on GitHub and Buildkite.

However, we no longer need to do this as of https://phabricator.ashoat.com/D4097.

Test Plan

See if Buildkite CI passes (on arc diff) and if GH Actions CI passes (on arc land)

Diff Detail

Repository
rCOMM Comm
Branch
landmay24
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added inline comments.
.buildkite/eslint_flow_jest.yml
6 ↗(On Diff #13075)

Also snuck in this change to clean things up

Before:

- 'cd lib && yarn test'
- 'cd ../keyserver && yarn test'
atul requested review of this revision.May 24 2022, 6:51 AM
This revision is now accepted and ready to land.May 24 2022, 7:02 AM
This revision was automatically updated to reflect the committed changes.