When we're in chat, calendar or apps, we should mark the icon with purple rectangle.
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77595
Depends on D4144
Details
Details
Check if the icon is marked while on apps, chat or calendar. It shouldn't be marked while on settings page.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ENG-835
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/sidebar/community-picker.react.js | ||
|---|---|---|
| 41–46 | I think alternatively we could "re-use" the isSettingsOpen selector and below do something like: const inboxButtonContainerClass = classNames({
[css.activeContainer]: !isSettingsOpen,
}).to avoid a second useSelector... but overall I think your approach is probably more robust and it's better to be explicit. | |
| web/sidebar/community-picker.react.js | ||
|---|---|---|
| 41–46 | I prefer being explicit here - just to avoid possible bugs in the future. On the other hand, possible bugs would be easy to catch. | |