I think we should have all proto files in one place. Therefore, here I'm moving the proto for identity service to native where all protos are. We can either do that or move all protos to another location but I'd have them in one place.
Additionally, I changed the folder name on the docker image from proto to protos. I this plural is better here because we may have multiple protos in each service (in the case of interservice communication, we already have that in the backup service), plus it's like this in other services so we should probably stay consistent about this.
Details
- Reviewers
varun • jim - Commits
- rCOMMe4855f477431: [services] Identity - Fix proto file location
Not sure how Varun has been testing the identity so far but this should work:
cd services/identity docker-compose up --build identity-server
For now it kind of hangs, but I added explicitly:
println!("Hello"); return Ok(());
in the beginning of the main function in the main.rs file and it prints Hello. That means it successfully copies the proto file, then builds from this proto file and then compiles the sources, so I consider it working.
Diff Detail
- Repository
- rCOMM Comm
- Branch
- fix-identity
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Agree with keeping all the protos in one place. I think this will be a good thing for when we eventually need to call the identity service from native.
That said it's probably kind of weird that we keep all of the protos in native specifically... I think it would make more sense for them to be in services somewhere, or maybe in a separate top-level directory altogether. (This can definitely be a separate diff.)
Eventually we'll probably want to access some of the services from web as well, at which point native will make less sense.
This is fine, but I also think that long term the protos should live in the services directory instead of native
I created a task to track moving the protos folder: https://linear.app/comm/issue/ENG-1231/find-a-better-place-to-store-services-protos