This diff removes networks from the services docker-compose file to use the default shared network and omit complex network setup.
Linear task: ENG-774
Details
Details
Run yarn run-tunnelbroker-service-dev-mode and connect to the localstack and rabbitmq service by the hostnames localstack and rabbitmq respectively from inside of the tunnelbroker container.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- add-networks-to-tunnelbroker
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
What's the point of defining a network and then just connecting every single container to it? Isn't that the default behavior of Docker Compose?
I think we can simply remove all of the networks: sections (in the root and for each service) and everything should just work the same. Do we have any plans for a more complex network topology that justifies the extra boilerplate?
Comment Actions
Yes, I think we can remove the networks: sections. It was added to follow the existing configuration only.
I can change this diff to remove all the networks: sections.
Do we have any plans for a more complex network topology that justifies the extra boilerplate?
From the tunnelbroker perspective, we don't have such plans for now. Will any other services need it? cc @karol-bisztyga , @varun.
Comment Actions
Resigning to remove this from my queue, while leaving it on others' queue. My perspective is that networks: should be removed for now since it is doing nothing, and we can reintroduce it later if/when we decide we need it
Comment Actions
Do we have any plans for a more complex network topology that justifies the extra boilerplate?
From the tunnelbroker perspective, we don't have such plans for now. Will any other services need it? cc @karol-bisztyga , @varun.
I think the Identity service can just use the default network
Comment Actions
Requesting changes because it looks like we don't need to specify networks. We're using it in a couple of place, so it might be a good idea to delete all of the usages.