[services] Backup - Add chunk counter to the pull backup reactor
AbandonedPublic
Actions

Authored by • karol on Jun 7 2022, 6:52 AM.

Details

Reviewers

tomek
• max
varun

Summary

Depends on D4229

Using the current chunk counter introduced in D229 in a way mentioned in that diff:

With the chunk counter, we can easily recognize when we get a new log - whenever the counter is 0.

Test Plan

Please see D4216

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.Jun 7 2022, 6:52 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptJun 7 2022, 6:52 AM

Harbormaster completed remote builds in B9659: Diff 13386.Jun 7 2022, 7:25 AM

• karol requested review of this revision.Jun 7 2022, 7:25 AM

• karol edited the summary of this revision. (Show Details)Jun 7 2022, 8:23 AM

• karol edited the test plan for this revision. (Show Details)

• karol added reviewers: tomek, • max, varun.

• karol added a parent revision: D4229: [services] Backup - Add chunk counter to proto.

• karol added a child revision: D4232: [services] Backup - Stop suppressing invalid chunk structure.Jun 7 2022, 8:34 AM

ashoat mentioned this in D4229: [services] Backup - Add chunk counter to proto.Jun 7 2022, 4:12 PM

• karol abandoned this revision.Jun 13 2022, 5:24 AM

• karol removed a child revision: D4232: [services] Backup - Stop suppressing invalid chunk structure.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

PullBackupReactor.h

1 line

PullBackupReactor.cpp

6 lines

Diff 13386

View Options

services/backup/src/Reactors/server/PullBackupReactor.h