[docs] Update Phabricator instructions in dev_environment.md
ClosedPublic
Actions

Authored by ashoat on Jun 13 2022, 2:23 PM.

Details

Reviewers

varun
atul
tomek

Commits

rCOMM7ba2acb085c0: [docs] Update Phabricator instructions in dev_environment.md

Summary

These instructions are really confusing. They go too deep on things you really should not be doing, and don't explain things that you really need to understand.

This diff attempts to simplify the instructions by removing the unneeded parts, and also adds some things that everybody needs to know.

Linear task: ENG-427

Test Plan

I read through my edits carefully and made sure I don't have any stray single- or double-quote characters

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/docs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 13 2022, 2:23 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJun 13 2022, 2:23 PM

Hmmm not sure what's going on with CI, but this is a docs diff so I'm sure it doesn't matter

Harbormaster completed remote builds in B9732: Diff 13477.Jun 14 2022, 2:51 AM

varun requested changes to this revision.Jun 14 2022, 6:48 AM

varun added inline comments.

docs/dev_environment.md
816 ↗	(On Diff #13477)	I think you can omit the `Differential Revision:` stuff here since it's explained in the next section anyway
830 ↗	(On Diff #13477)	Is this official terminology or should we put it in quotes?