Enable rescinding from AppDelegate on iOS
ClosedPublic
Actions

Authored by marcin on Jun 7 2022, 6:49 AM.

Details

Reviewers

tomek

Commits

rCOMM6cdcbcd44277: Enable rescinding from AppDelegate on iOS

Summary

This differential removes codeVersion blockade that prevented us from rescinding notifications via AppDelegate callbacks.

Test Plan

Create rescinding environment for iOS - one web client A and two clients B (mobile and web). Send message from A to B and read it on web version of B. Check in XCode debugger that rescinding code in AppDelegate is executed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jun 7 2022, 6:49 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 7 2022, 6:49 AM

marcin added a child revision: D4231: Introduce threadID to iOS rescind notification to enable easy SQLite update. Introduce setUnreadStatus flag to control whether to update SQLite in response to rescind.Jun 7 2022, 6:59 AM

Harbormaster completed remote builds in B9655: Diff 13381.Jun 7 2022, 7:20 AM

marcin requested review of this revision.Jun 7 2022, 7:20 AM

This is probably obvious, but worth mentioning: we should make sure we only land this diff in combination with the client changes... if we end up accidentally releasing codeVersion 132 without the client changes, it would cause some trouble

tomek accepted this revision.Jun 8 2022, 6:32 AM

This revision is now accepted and ready to land.Jun 8 2022, 6:32 AM

Rebase to master after CI change

Harbormaster failed remote builds in B9692: Diff 13433!Jun 8 2022, 6:45 AM

Harbormaster completed remote builds in B9692: Diff 13433.Jun 8 2022, 7:28 AM

Bump codeVersion and rebase master

Harbormaster completed remote builds in B9822: Diff 13586.Jun 20 2022, 2:53 AM

Closed by commit rCOMM6cdcbcd44277: Enable rescinding from AppDelegate on iOS (authored by marcin). · Explain WhyJun 20 2022, 3:30 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM6cdcbcd44277: Enable rescinding from AppDelegate on iOS.