[lib] Update `messageStore.messages` with `msgStoreOps` for createLocalMessage
ClosedPublic
Actions

Authored by atul on Jun 2 2022, 7:03 PM.

Details

Reviewers

• jacek
tomek

Commits

rCOMM2fe7bd742662: [lib] Update `messageStore.messages` with `msgStoreOps` for createLocalMessage

Summary

Instead of using messageStore.messages from the previous updatedMessageStore object... we pull it from the processedMessageStore object.

We actually remove updatedMessageStore altogether and include the changes to updatedMessageStore.threads in the messageStore of the returned object.

Depends on D4203

Test Plan

This should be a straightforward refactor given we've had assertMessageStoreMessagesAreEqual in place for some time now.

Diff Detail

Repository

rCOMM Comm

Branch

landjune21 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 2 2022, 7:03 PM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJun 2 2022, 7:03 PM

Harbormaster completed remote builds in B9609: Diff 13320.Jun 2 2022, 7:08 PM

atul requested review of this revision.Jun 2 2022, 7:08 PM

atul added a child revision: D4205: [lib] Update `messageStore.messages` with `msgStoreOps` for updateMultimediaMessageMedia.Jun 2 2022, 8:19 PM

tomek requested changes to this revision.Jun 3 2022, 4:32 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1380–1387 ↗	(On Diff #13320)	We were comparing `updatedMessageStore` with `processedMessageStore` so maybe we should use `processedMessageStore`. Additional modification of `threads` is concerning - are you sure we need that?

This revision now requires changes to proceed.Jun 3 2022, 4:32 AM

atul requested review of this revision.Jun 17 2022, 1:47 PM

atul added inline comments.

lib/reducers/message-reducer.js
1380–1387 ↗	(On Diff #13320)	Right now the "ops-approach" only modifies `messageStore.messages`, we'll need to "get the rest" of the messageStore using the old way `isEqual(messageStore, updatedMessageStore) === false` `isEqual(messageStore.messages, updatedMessageStore) === true`

tomek accepted this revision.Jun 20 2022, 3:09 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1380–1387 ↗	(On Diff #13320)	We were asserting that `updatedMessageStore` and `processedMessageStore` had the same content so it should be possible to use `processedMessageStore`. Am I missing something?

This revision is now accepted and ready to land.Jun 20 2022, 3:09 AM

atul added inline comments.Jun 22 2022, 12:08 AM

lib/reducers/message-reducer.js
1380–1387 ↗	(On Diff #13320)	We were asserting that `updatedMessageStore.messages` and `processedMessageStore.messages` had the same content, but for example `updatedMessageStore.threads` and `processedMessageStore.threads` will be different