Paths

Table of Contentst

[services] refactor some if let statements to reduce nesting
ClosedPublic
Actions

Authored by varun on Jun 28 2022, 11:19 AM.

Tags

None

Referenced Files

	F3280494: D4386.diff
	Sat, Nov 16, 9:11 AM

	Unknown Object (File)
	Sat, Nov 9, 11:41 AM

	Unknown Object (File)
	Sat, Nov 9, 11:40 AM

	Unknown Object (File)
	Fri, Nov 8, 8:08 AM

	Unknown Object (File)
	Tue, Nov 5, 2:02 AM

	Unknown Object (File)
	Mon, Oct 21, 8:11 PM

	Unknown Object (File)
	Mon, Oct 21, 7:52 AM

	Unknown Object (File)
	Oct 15 2024, 4:55 PM

Subscribers

Details

Reviewers

tomek
• karol
• jim

Commits

rCOMM3cecc94df5c1: [services] refactor some if let statements to reduce nesting

Summary

pretty straightforward refactor. resolves [ENG-1305 : Refactor if let error handling](https://linear.app/comm/issue/ENG-1305/refactor-if-let-error-handling)

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Branch

ENG-1305

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 28 2022, 11:19 AM

Herald added subscribers: • abosh, atul, • adrian, ashoat. · View Herald TranscriptJun 28 2022, 11:19 AM

Harbormaster completed remote builds in B10061: Diff 13910.Jun 28 2022, 11:29 AM

varun requested review of this revision.Jun 28 2022, 11:29 AM

tomek accepted this revision.Jun 29 2022, 4:07 AM

This revision is now accepted and ready to land.Jun 29 2022, 4:07 AM

Closed by commit rCOMM3cecc94df5c1: [services] refactor some if let statements to reduce nesting (authored by varun). · Explain WhyJun 29 2022, 7:03 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3cecc94df5c1: [services] refactor some if let statements to reduce nesting.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

service.rs

225 lines

Diff 13910

View Options

services/identity/src/service.rs

[services] refactor some if let statements to reduce nestingClosedPublicActions