Page MenuHomePhabricator
Differential D4388

[services] create constants module for identity service
ClosedPublic
Actions

Authored by varun on Jun 28 2022, 1:15 PM.
Tags
None
Referenced Files
F3267560: D4388.id13963.diff
Sat, Nov 16, 2:53 AM
F3267510: D4388.id13913.diff
Sat, Nov 16, 2:49 AM
F3263812: D4388.diff
Sat, Nov 16, 12:17 AM
Unknown Object (File)
Wed, Oct 23, 4:25 PM
Unknown Object (File)
Tue, Oct 22, 8:14 PM
Unknown Object (File)
Tue, Oct 22, 11:26 AM
Unknown Object (File)
Tue, Oct 22, 11:26 AM
Unknown Object (File)
Mon, Oct 21, 11:15 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul

Details

Reviewers
tomek
• karol
• jim
Commits
rCOMMa32e89da6502: [services] create constants module for identity service
Summary

A single location for all const values in the identity service. Resolves https://linear.app/comm/issue/ENG-1174/create-constants-module

Test Plan

Checked all places where I swapped out a hardcoded value for const variable name, cargo build

Diff Detail

Repository
rCOMM Comm
Branch
varun/eng-1174-create-constants-module
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
identity/
src/
10 lines
28 lines
63 lines
5 lines
7 lines
5 lines
4 lines

Diff 13913

View Options

services/identity/src/config.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/keygen.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

services/identity/src/service.rs

Loading...
View Options

services/identity/src/token.rs

Loading...