Page MenuHomePhabricator

[services] redact server keypair in config struct
ClosedPublic

Authored by varun on Jun 28 2022, 12:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 8:08 AM
Unknown Object (File)
Tue, Nov 5, 2:02 AM
Unknown Object (File)
Tue, Oct 29, 3:19 PM
Unknown Object (File)
Mon, Oct 28, 8:54 AM
Unknown Object (File)
Oct 16 2024, 7:59 PM
Unknown Object (File)
Oct 15 2024, 5:31 PM

Details

Summary

We should not reveal the keypair in our logs. I've manually implemented the Debug trait to redact the server_keypair field.

Resolves https://linear.app/comm/issue/ENG-1298/redact-sensitive-fields-in-types-that-implement-debug-trait

Test Plan

Printed the Config struct and confirmed the keypair field was redacted

Config { server_keypair: "redacted" }

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable