Page MenuHomePhabricator

[web] Rename `MessageActionButtons` to `MessageTooltip`
ClosedPublic

Authored by abosh on Jul 1 2022, 2:05 PM.
Tags
None
Referenced Files
F2185376: D4426.id14188.diff
Wed, Jul 3, 11:55 PM
F2185367: D4426.id14098.diff
Wed, Jul 3, 11:54 PM
F2185314: D4426.id14189.diff
Wed, Jul 3, 11:43 PM
F2178640: D4426.id14098.diff
Wed, Jul 3, 11:15 AM
Unknown Object (File)
Tue, Jul 2, 1:41 PM
Unknown Object (File)
Tue, Jul 2, 11:40 AM
Unknown Object (File)
Tue, Jul 2, 8:48 AM
Unknown Object (File)
Tue, Jul 2, 7:27 AM
Subscribers

Details

Summary

Relevant Linear issue here. @ashoat and I discussed this today and determined that since the timestamp was moved into MessageActionButtons (see D3571) it doesn't make sense that the component called MessageActionButtons contains the action buttons and the timestamp. Instead, renamed it to something that better encapsulates the component, which is a tooltip that opens when a user hovers over a message or RobotextMessage.

Test Plan

Replaced all occurrences of MessageActionButtons, messageAction that had to do with MessageActionButtons. Did not replace the instances of messageActionButtons in the CSS for MessageActionButtons because those were actually pertaining to the message ation buttons. Everything else (like in ComposedMessage or RobotextMessage) were just referring to the tooltip as a whole.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2022, 2:06 PM
Harbormaster failed remote builds in B10213: Diff 14097!
tomek added inline comments.
web/chat/composed-message.react.js
148 ↗(On Diff #14098)
This revision is now accepted and ready to land.Jul 4 2022, 6:06 AM

address inline feedback (had a lowercase m)

This revision was landed with ongoing or failed builds.Jul 5 2022, 7:22 AM
This revision was automatically updated to reflect the committed changes.