Page MenuHomePhabricator
Differential D3571

[web] Add message timestamp to `MessageActionButtons` component
ClosedPublic
Actions

Authored by atul on Mar 30 2022, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 12:41 AM
Unknown Object (File)
Mon, Jun 24, 4:26 PM
Unknown Object (File)
Mon, Jun 17, 12:50 PM
Unknown Object (File)
May 24 2024, 8:50 AM
Unknown Object (File)
May 20 2024, 2:13 AM
Unknown Object (File)
May 7 2024, 2:29 AM
Unknown Object (File)
Apr 29 2024, 7:37 AM
Unknown Object (File)
Apr 29 2024, 7:37 AM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
• jacek
tomek
ashoat
• benschac
Commits
rCOMMb5745bc3701b: [web] Add message timestamp to `MessageActionButtons` component
Summary

Display message timestamp in MessageActionButtons on hover. Additional context here: https://linear.app/comm/issue/ENG-799/message-tooltip-position-is-incorrect

Depends on D3570

Test Plan

Looks as expected:

052e-1.png (768×592 px, 58 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 30 2022, 11:55 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 30 2022, 11:55 AM
atul published this revision for review.Mar 30 2022, 11:56 AM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B7728: Diff 10842.Mar 30 2022, 12:02 PM
ashoat accepted this revision.Mar 30 2022, 11:10 PM

Didn't review this super closely, but it seems to look good

This revision is now accepted and ready to land.Mar 30 2022, 11:10 PM
atul updated this revision to Diff 10907.Mar 31 2022, 9:37 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 31 2022, 9:44 AM
Closed by commit rCOMMb5745bc3701b: [web] Add message timestamp to `MessageActionButtons` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb5745bc3701b: [web] Add message timestamp to `MessageActionButtons` component.
Harbormaster completed remote builds in B7775: Diff 10907.Mar 31 2022, 9:51 AM
• abosh mentioned this in D4426: [web] Rename `MessageActionButtons` to `MessageTooltip`.Jul 1 2022, 2:05 PM
• abosh mentioned this in rCOMM0b35e94151d2: [web] Rename `MessageActionButtons` to `MessageTooltip`.Jul 5 2022, 7:22 AM

Revision Contents
Changeset List

Diff 10908

View Options

web/chat/message-action-buttons.css

Loading...
View Options

web/chat/message-action-buttons.js

Loading...