Page MenuHomePhabricator
Differential D3570

[web] Remove `MessageTimestampTooltip` component and associated styles
ClosedPublic
Actions

Authored by atul on Mar 30 2022, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 3:23 PM
Unknown Object (File)
Fri, Nov 8, 3:23 PM
Unknown Object (File)
Fri, Nov 8, 3:23 PM
Unknown Object (File)
Fri, Nov 8, 3:22 PM
Unknown Object (File)
Fri, Nov 8, 3:19 PM
Unknown Object (File)
Sun, Nov 3, 2:10 AM
Unknown Object (File)
Fri, Nov 1, 10:46 AM
Unknown Object (File)
Wed, Oct 23, 10:37 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
ashoat
• jacek
tomek
• benschac
Commits
rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles
Summary

Remove the MessageTimestampTooltip which we will no longer need once we incorporate message timestamp into the MessageActionButtons component.

Next diff:

  1. Display timestamp as part of MessageActionButtons component.

Depends on D3567

Test Plan

flow? all usages of component were removed in the previous diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 30 2022, 11:25 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 30 2022, 11:25 AM
atul added inline comments.Mar 30 2022, 11:29 AM
web/chat/chat-message-list.css
54 ↗(On Diff #10841)

Searched messageLeftTooltip in codebase and found no relevant occurrences.

59 ↗(On Diff #10841)

Searched messageRightTooltip in codebase and found no relevant occurrences.

64 ↗(On Diff #10841)

Searched messageTopLeftTooltip in codebase and found no occurrences.

69 ↗(On Diff #10841)

Searched messageTopRightTooltip in codebase and found no occurrences.

74 ↗(On Diff #10841)

Searched messageBottomLeftTooltip in codebase and found no occurrences.

79 ↗(On Diff #10841)

Searched messageBottomRightTooltip in codebase and found no occurrences.

atul published this revision for review.Mar 30 2022, 11:29 AM
Harbormaster completed remote builds in B7727: Diff 10841.Mar 30 2022, 11:32 AM
atul added a child revision: D3571: [web] Add message timestamp to `MessageActionButtons` component.Mar 30 2022, 11:55 AM
ashoat accepted this revision.Mar 30 2022, 11:09 PM
This revision is now accepted and ready to land.Mar 30 2022, 11:09 PM
atul updated this revision to Diff 10905.Mar 31 2022, 9:34 AM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 31 2022, 9:35 AM
Closed by commit rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles.
Harbormaster completed remote builds in B7774: Diff 10905.Mar 31 2022, 9:44 AM

Revision Contents
Changeset List

Diff 10906

View Options

web/chat/chat-message-list.css

Loading...
View Options

web/chat/message-timestamp-tooltip.react.js

Loading...