Page MenuHomePhabricator
Differential D4541

[chore] Replace `'` with `’` in user-displayed text
ClosedPublic
Actions

Authored by • abosh on Jul 14 2022, 1:14 PM.
Tags
None
Referenced Files
F4954404: D4541.diff
Fri, Mar 21, 8:29 AM
Unknown Object (File)
Tue, Mar 18, 1:34 PM
Unknown Object (File)
Thu, Feb 27, 1:08 PM
Unknown Object (File)
Wed, Feb 26, 4:27 PM
Unknown Object (File)
Wed, Feb 26, 4:27 PM
Unknown Object (File)
Wed, Feb 26, 4:12 PM
Unknown Object (File)
Feb 16 2025, 1:11 PM
Unknown Object (File)
Jan 30 2025, 10:01 PM
View All Files
Subscribers
• adrian
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMM4cdbb7da56d5: [chore] Replace `'` with `’` in user-displayed text
Summary

Replaced single quote with apostrophe in user-displayed text. Wasn't sure the best way to title this, but basically this diff only replaces the single quotes in text that can get displayed in a modal, the app, or an error message that isn't an invariant.

Test Plan

Used this regex to search for all instances of ' surrounded by "":

image.png (324×524 px, 25 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• abosh created this revision.Jul 14 2022, 1:14 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJul 14 2022, 1:14 PM
• abosh edited the test plan for this revision. (Show Details)Jul 14 2022, 1:14 PM
• abosh edited the summary of this revision. (Show Details)
• abosh added inline comments.
lib/facts/genesis.json
1

Not sure where this or testers.json is used anymore, but it's human-readable/user-displayed text somewhere, so I changed it.

Harbormaster completed remote builds in B10538: Diff 14503.Jul 14 2022, 1:26 PM
• abosh requested review of this revision.Jul 14 2022, 1:26 PM
atul accepted this revision.Jul 14 2022, 5:49 PM

Seems reasonable. It might be hard to keep it this way in the codebase since the ' key is a single quote in code editors.

There's probably some way to enforce the rule, but I don't think it really matters enough to go through that effort.

This revision is now accepted and ready to land.Jul 14 2022, 5:49 PM
• abosh added a comment.Jul 15 2022, 7:52 AM

Yeah, it just depends on how stringent future code reviewers want to be.

Closed by commit rCOMM4cdbb7da56d5: [chore] Replace `'` with `’` in user-displayed text (authored by • abosh). · Explain WhyJul 15 2022, 7:53 AM
This revision was automatically updated to reflect the committed changes.
• abosh added a commit: rCOMM4cdbb7da56d5: [chore] Replace `'` with `’` in user-displayed text.
• abosh mentioned this in D5040: [lib] Use slanted apostrophes and quotation marks in `change-settings-message-spec`.Sep 15 2022, 4:07 PM

Revision Contents
Changeset List

PathSize
lib/
facts/
4 lines
4 lines
shared/
6 lines
native/
account/
6 lines
4 lines
media/
2 lines
2 lines
profile/
2 lines
redux/
4 lines
web/
settings/
2 lines

Diff 14503

View Options

lib/facts/genesis.json

Loading...
View Options

lib/facts/testers.json

Loading...
View Options

lib/shared/search-utils.js

Loading...
View Options

native/account/log-in-panel.react.js

Loading...
View Options

native/account/register-panel.react.js

Loading...
View Options

native/media/camera-modal.react.js

Loading...
View Options

native/media/save-media.js

Loading...
View Options

native/profile/edit-password.react.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/settings/password-change-modal.js

Loading...