Details

Reviewers

tomek
atul
ashoat

Commits

rCOMMeb3eda765d15: use dispatch on main queue
rCOMMd7d5a7ee136c: use dispatch on main queue

Summary

Ths differential overwrites solution from its parent diff. Instead of waiting to call completionHandler until rescinding loop completes, we schedult its call on main thread.

Test Plan

Test plan is the same as for its parent diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Jul 19 2022, 5:36 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 19 2022, 5:36 AM

marcin added a parent revision: D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 5:38 AM

Harbormaster completed remote builds in B10638: Diff 14637.Jul 19 2022, 5:49 AM

marcin requested review of this revision.Jul 19 2022, 5:49 AM

ashoat mentioned this in D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 6:45 AM

Can you rebase this on top of master so we can land it and @atul can create a new staff-only release? I want to test this in a production environment to see if it works

This revision is now accepted and ready to land.Jul 19 2022, 9:44 AM

Rebase master before landing

This revision was landed with ongoing or failed builds.Jul 19 2022, 10:02 AM

Closed by commit rCOMMd7d5a7ee136c: use dispatch on main queue (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMd7d5a7ee136c: use dispatch on main queue.

Harbormaster completed remote builds in B10652: Diff 14652.Jul 19 2022, 10:08 AM

In D4576#130617, @ashoat wrote:

Can you rebase this on top of master so we can land it and @atul can create a new staff-only release? I want to test this in a production environment to see if it works

Should I go ahead and do that right now?

marcin added a reverting change: rCOMM04107397098d: Revert "use dispatch on main queue".Jul 19 2022, 11:18 AM

marcin reopened this revision.Jul 19 2022, 11:24 AM

This revision is now accepted and ready to land.Jul 19 2022, 11:24 AM

Reordering diff after inaccurate landing

marcin removed a parent revision: D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 11:26 AM

marcin added a child revision: D4573: Place call to completionHandler outside rescinding callback so that we avoid app being killed by the system.Jul 19 2022, 11:30 AM

marcin added a parent revision: D4572: change thread operations utilities paths in XCode so that they can be debugged.

Harbormaster completed remote builds in B10654: Diff 14660.Jul 19 2022, 11:37 AM

Closed by commit rCOMMeb3eda765d15: use dispatch on main queue (authored by marcin). · Explain WhyJul 19 2022, 11:39 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMMeb3eda765d15: use dispatch on main queue.