[services] add GetUserID RPC
ClosedPublic
Actions

Authored by varun on Jul 22 2022, 1:19 PM.

Details

Reviewers

ashoat
tomek
• karol
• max
• derek

Commits

rCOMMdf426a3182a0: [services] add GetUserID RPC

Summary

Users and keyservers need to be able to retrieve the userID corresponding to some given user info (username in the case of password auth and wallet address in the case of wallet auth). This RPC exposes that functionality.

Depends on D4613

Test Plan

Checked syntax with linter, identity service build succeeded

Diff Detail

Repository

rCOMM Comm

Branch

update-proto

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jul 22 2022, 1:19 PM

Herald added subscribers: • abosh, atul, • adrian. · View Herald TranscriptJul 22 2022, 1:19 PM

Harbormaster completed remote builds in B10782: Diff 14823.Jul 22 2022, 1:31 PM

varun requested review of this revision.Jul 22 2022, 1:31 PM

ashoat accepted this revision.Jul 25 2022, 5:53 AM

ashoat added inline comments.

native/cpp/CommonCpp/grpc/protos/identity.proto
130–133	Oh that's cool, didn't know you could define these inside another definition
135	On one hand, we could try to be more specific here and have a different result type depending on the `AuthType`. But after thinking about it a bit I think it's probably not worth it... this approach is more simple and more extensible for other kinds of auth in the future. (We will need to add Apple Auth in order to support SIWE on iOS, for instance)