Page MenuHomePhabricator
Differential D4619

[lintstaged] Add Jest tests to `.lintstaged.js`
ClosedPublic
Actions

Authored by atul on Jul 25 2022, 7:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:27 PM
Unknown Object (File)
Fri, Nov 8, 1:27 PM
Unknown Object (File)
Fri, Nov 8, 3:56 AM
Unknown Object (File)
Oct 28 2024, 5:08 AM
Unknown Object (File)
Oct 28 2024, 5:08 AM
Unknown Object (File)
Oct 28 2024, 5:08 AM
Unknown Object (File)
Oct 28 2024, 5:08 AM
Unknown Object (File)
Oct 28 2024, 5:05 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
• abosh
varun
tomek
Commits
rCOMMddf524180469: [lintstaged] Add Jest tests to `.lintstaged.js`
Summary

Run lib and keyserver tests for the same conditions that flow is run in those directories.

Test Plan

Proof that the tests run:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jul 25 2022, 7:17 AM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptJul 25 2022, 7:17 AM
atul edited the test plan for this revision. (Show Details)Jul 25 2022, 7:20 AM
Harbormaster completed remote builds in B10807: Diff 14866.Jul 25 2022, 7:27 AM
atul requested review of this revision.Jul 25 2022, 7:27 AM
• abosh requested changes to this revision.Jul 25 2022, 7:40 AM
• abosh added inline comments.
.lintstagedrc.js
29–33 ↗(On Diff #14866)

Shouldn't we be running yarn ... flow in the keyServerFlow method (like it was before) and not keyServerTest? I think you may have swapped the method bodies, just judging off the syntax of commands and the corresponding method name?

This revision now requires changes to proceed.Jul 25 2022, 7:40 AM
atul updated this revision to Diff 14867.Jul 25 2022, 7:43 AM

fix small thing

.lintstagedrc.js
29–33 ↗(On Diff #14866)

Yes! Good catch, thank you.

Re-made the changes because of some extraneous ESLint stuff, but wasn't careful when copy/pasting.

• abosh accepted this revision.Jul 25 2022, 7:45 AM

Looks good!

This revision is now accepted and ready to land.Jul 25 2022, 7:45 AM
atul added a reviewer: varun.Jul 25 2022, 7:54 AM
This revision now requires review to proceed.Jul 25 2022, 7:54 AM
Harbormaster completed remote builds in B10808: Diff 14867.Jul 25 2022, 7:56 AM
atul added 1 blocking reviewer(s): tomek.Jul 25 2022, 8:48 AM
varun accepted this revision.Jul 25 2022, 8:55 AM

nit: consider changing the function names to libTest or keyServerJest for the sake of parallelism

also, we should change keyServer to keyserver in a couple places in this file

atul removed a reviewer: tomek.Jul 25 2022, 8:59 AM
This revision is now accepted and ready to land.Jul 25 2022, 8:59 AM
atul added a reviewer: tomek.Jul 25 2022, 8:59 AM
atul updated this revision to Diff 14871.Jul 25 2022, 9:05 AM

address feedback from @varun

atul added a comment.Jul 25 2022, 9:06 AM

nit: consider changing the function names to libTest or keyServerJest for the sake of parallelism

good point, made them both blahTest

• abosh accepted this revision.Jul 25 2022, 9:07 AM
Harbormaster completed remote builds in B10812: Diff 14871.Jul 25 2022, 9:18 AM
Closed by commit rCOMMddf524180469: [lintstaged] Add Jest tests to `.lintstaged.js` (authored by atul). · Explain WhyJul 25 2022, 10:02 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMddf524180469: [lintstaged] Add Jest tests to `.lintstaged.js`.

Revision Contents
Changeset List

PathSize
6 lines

Diff 14873

View Options

.lintstagedrc.js

Loading...