Page MenuHomePhabricator

[blob] Use `FetchContent_Declare` to pull in `gRPC`
AbandonedPublicDraft

Authored by atul on Jul 25 2022, 11:42 AM.
Tags
None
Referenced Files
F3537200: D4625.id14885.diff
Wed, Dec 25, 8:27 PM
F3537038: D4625.id14886.diff
Wed, Dec 25, 7:56 PM
F3537033: D4625.id14887.diff
Wed, Dec 25, 7:54 PM
F3536910: D4625.id14884.diff
Wed, Dec 25, 7:28 PM
F3536903: D4625.id14888.diff
Wed, Dec 25, 7:27 PM
Unknown Object (File)
Mon, Dec 16, 12:44 AM
Unknown Object (File)
Sun, Dec 15, 4:51 PM
Unknown Object (File)
Sun, Dec 15, 4:00 PM
Subscribers

Details

Summary

Context from D4624 (replace glog with gRPC):
Right now we handle dependencies for services in a very weird way that depends on various shell scripts and assumes a Docker environment built atop the base-image.

This diff uses the CMake FetchContent_Declare functionality to pull in the correct version of glog (as described in services/base-image/docker/install_glog.sh) without depending on a shell script/base image.

In my opinion it makes way more sense for each service to handle required dependencies rather than assuming there's some "base image" that magically takes care of things.

The coupling of services builds with assumption of Docker environment leads to CMake projects that aren't portable... making it impossible to get things to work directly on dev machines. IMO the right level of abstraction for handling dependencies is the build system (in this case CMake).


Depends on D4624

Test Plan

Blob CI continues to work.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 11:45 AM
Harbormaster failed remote builds in B10821: Diff 14884!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 11:54 AM
Harbormaster failed remote builds in B10822: Diff 14885!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 12:00 PM
Harbormaster failed remote builds in B10823: Diff 14886!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 12:07 PM
Harbormaster failed remote builds in B10824: Diff 14887!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2022, 12:10 PM
Harbormaster failed remote builds in B10825: Diff 14888!