Page MenuHomePhabricator
Differential D4644

[lib] Rename `locallyUnique...` to `pending...` to improve readability
ClosedPublic
Actions

Authored by • jacek on Jul 26 2022, 7:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 1:02 PM
Unknown Object (File)
Fri, Nov 29, 7:34 AM
Unknown Object (File)
Fri, Nov 15, 5:53 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:01 PM
Unknown Object (File)
Fri, Nov 8, 2:59 PM
Unknown Object (File)
Sep 26 2024, 11:40 PM
View All 79 Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM12df9759f072: [lib] Rename `locallyUnique...` to `pending...` to improve readability
Summary

Follow-up after D4443. The diff reverts renaming pending to locallyUnique made a few months ago.
Linear: https://linear.app/comm/issue/ENG-1374/rename-locallyuniquethreadid-to-pendingthreadid

Test Plan

Web and mobile apps build correctly and work as before. Confirmed, that features using locallyUnique/pending IDs still works correctly - e.g. thread creation and storing drafts for pending threads.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 26 2022, 7:31 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 26 2022, 7:31 AM
Harbormaster completed remote builds in B10894: Diff 14981.Jul 26 2022, 7:41 AM
• jacek requested review of this revision.Jul 26 2022, 7:41 AM
atul accepted this revision.Jul 26 2022, 11:33 AM

Looks good.

(Also searched for each of the new names in the codebase to make sure there weren't any collisions, and couldn't find any)

This revision is now accepted and ready to land.Jul 26 2022, 11:33 AM
Closed by commit rCOMM12df9759f072: [lib] Rename `locallyUnique...` to `pending...` to improve readability (authored by • jacek). · Explain WhyJul 27 2022, 7:18 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMM12df9759f072: [lib] Rename `locallyUnique...` to `pending...` to improve readability.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines
lib/
reducers/
14 lines
selectors/
16 lines
shared/
42 lines
40 lines
utils/
4 lines
native/
chat/
17 lines
web/
input/
14 lines
redux/
8 lines

Diff 15015

View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/selectors/thread-selectors.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/utils/url-utils.js

Loading...
View Options

native/chat/thread-draft-updater.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/redux/nav-reducer.js

Loading...