Differential D4660

[Nix] Rephrase motivation behind pinning to better reflect upstream
ClosedPublic
Actions

Authored by • jon on Jul 27 2022, 5:13 PM.

Details

Reviewers

ashoat

Commits

rCOMMdbe97ad840bf: [Nix] Rephrase motivation behind pinning to better reflect upstream

Summary

Address https://phab.comm.dev/D4646#133604

Previous wording reduced options to only the await option. When json imports
can also use asserts. Instead, better align with upstream language.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Jul 27 2022, 5:13 PM

Herald added subscribers: • abosh, atul, • adrian, tomek. · View Herald TranscriptJul 27 2022, 5:13 PM

Harbormaster completed remote builds in B10924: Diff 15030.Jul 27 2022, 5:23 PM

• jon requested review of this revision.Jul 27 2022, 5:23 PM

• jon mentioned this in D4646: [Nix] Update nixpkgs pin.Jul 27 2022, 5:48 PM

• jon added a child revision: D4646: [Nix] Update nixpkgs pin.Jul 27 2022, 6:11 PM

• jon edited the summary of this revision. (Show Details)

Thank you for fixing this!

This revision is now accepted and ready to land.Jul 27 2022, 7:37 PM

Closed by commit rCOMMdbe97ad840bf: [Nix] Rephrase motivation behind pinning to better reflect upstream (authored by • jon). · Explain WhyJul 28 2022, 4:58 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMdbe97ad840bf: [Nix] Rephrase motivation behind pinning to better reflect upstream.

Revision Contents
Changeset List

Path

Size

nix/

overlay.nix

2 lines

Diff 15030

View Options

[Nix] Rephrase motivation behind pinning to better reflect upstreamClosedPublicActions