Page MenuHomePhabricator
Differential D4673

[keyserver] Add index to container column of uploads table
ClosedPublic
Actions

Authored by ashoat on Jul 28 2022, 11:19 PM.
Tags
None
Referenced Files
F3390147: D4673.id15084.diff
Fri, Nov 29, 10:26 PM
F3390130: D4673.id15095.diff
Fri, Nov 29, 10:20 PM
F3389675: D4673.diff
Fri, Nov 29, 8:08 PM
Unknown Object (File)
Tue, Nov 26, 11:38 AM
Unknown Object (File)
Thu, Nov 7, 4:49 AM
Unknown Object (File)
Wed, Nov 6, 3:56 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
View All 84 Files
Subscribers
• abosh
• adrian

Details

Reviewers
tomek
atul
Commits
rCOMM881ac1b3ec75: [keyserver] Add index to container column of uploads table
Summary

This is the first part of the stack to resolve ENG-1484. We'll start using it in message-fetchers.js in the following diff.

Test Plan

I first tested this stack locally in my environment to make sure the queries worked. Then I patched it onto my production keyserver and confirmed performance was improved

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 28 2022, 11:19 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 28 2022, 11:19 PM
ashoat added a child revision: D4674: [keyserver] Look up uploads for a message using the container column.Jul 28 2022, 11:20 PM
ashoat mentioned this in D4672: [lib] Bump all timeouts.Jul 28 2022, 11:28 PM
Harbormaster completed remote builds in B10962: Diff 15084.Jul 28 2022, 11:31 PM
ashoat requested review of this revision.Jul 28 2022, 11:31 PM
tomek accepted this revision.Jul 29 2022, 1:48 AM
This revision is now accepted and ready to land.Jul 29 2022, 1:48 AM
Closed by commit rCOMM881ac1b3ec75: [keyserver] Add index to container column of uploads table (authored by ashoat). · Explain WhyJul 29 2022, 8:33 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM881ac1b3ec75: [keyserver] Add index to container column of uploads table.
ashoat mentioned this in D4796: [keyserver] Revert D4675 window function for getMessageInfos.Aug 10 2022, 12:29 PM
atul added a comment.Aug 10 2022, 1:47 PM

Dang did this for the SQLite DB (D2060), I should've looked at the corresponding table in MySQL

ashoat mentioned this in rCOMM6cd531cc066a: [keyserver] Revert D4675 window function for getMessageInfos.Aug 10 2022, 2:13 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
7 lines
3 lines

Diff 15095

View Options

keyserver/src/database/migration-config.js

Loading...
View Options

keyserver/src/database/setup-db.js

Loading...