Page MenuHomePhabricator

[keyserver] Avoid passing dbType to mysql2 in getMigrationConnection
ClosedPublic

Authored by ashoat on Jul 28 2022, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 10:33 AM
Unknown Object (File)
Sun, Jun 30, 3:27 AM
Unknown Object (File)
Sat, Jun 29, 9:52 PM
Unknown Object (File)
Wed, Jun 26, 12:55 AM
Unknown Object (File)
Wed, Jun 26, 12:54 AM
Unknown Object (File)
Tue, Jun 25, 9:59 PM
Unknown Object (File)
Tue, Jun 18, 10:41 AM
Unknown Object (File)
Tue, Jun 18, 10:41 AM

Details

Summary

Otherwise we get this error printed:

Ignoring invalid configuration option passed to Connection: dbType. This is currently a warning, but in future versions of MySQL2, an error will be thrown if you pass an invalid configuration option to a Connection

See also D4529 and this update of D4516.

Depends on D4675

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable