[keyserver] Avoid passing dbType to mysql2 in getMigrationConnection
ClosedPublic
Actions

Authored by ashoat on Jul 28 2022, 11:21 PM.

Details

Reviewers

• jacek
tomek
atul

Commits

rCOMMa89052e0558c: [keyserver] Avoid passing dbType to mysql2 in getMigrationConnection

Summary

Otherwise we get this error printed:

Ignoring invalid configuration option passed to Connection: dbType. This is currently a warning, but in future versions of MySQL2, an error will be thrown if you pass an invalid configuration option to a Connection

See also D4529 and this update of D4516.

Depends on D4675

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 28 2022, 11:21 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 28 2022, 11:21 PM

Harbormaster completed remote builds in B10965: Diff 15087.Jul 28 2022, 11:33 PM

ashoat requested review of this revision.Jul 28 2022, 11:33 PM

tomek accepted this revision.Jul 29 2022, 4:57 AM

This revision is now accepted and ready to land.Jul 29 2022, 4:57 AM

Closed by commit rCOMMa89052e0558c: [keyserver] Avoid passing dbType to mysql2 in getMigrationConnection (authored by ashoat). · Explain WhyJul 29 2022, 8:33 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa89052e0558c: [keyserver] Avoid passing dbType to mysql2 in getMigrationConnection.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

database.js

5 lines

Diff 15098

View Options

keyserver/src/database/database.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines	if (!hasNonce) {
return (		return (
<div className={css.wrapper}>		<div className={css.wrapper}>
<div className={css.walletDisplay}>		<div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span>		<span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton />		<ConnectButton />
</div>		</div>
<p>{siweMessageSigningExplanationStatements[0]}</p>		<p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p>		<p>{siweMessageSigningExplanationStatements[1]}</p>
		<p>
		By signing up, you agree to our{' '}
		<a href="https://comm.app/terms">Terms of Use</a> &{' '}
		<a href="https://comm.app/privacy">Privacy Policy</a>.
		</p>
<div className={css.button} onClick={onClick}>		<div className={css.button} onClick={onClick}>
Sign in		Sign in
</div>		</div>
</div>		</div>
);		);
}		}
}		}

Show All 22 Lines

[keyserver] Avoid passing dbType to mysql2 in getMigrationConnectionClosedPublicActions