Page MenuHomePhabricator

[keyserver] Add dbType to DBConfig
ClosedPublic

Authored by ashoat on Jul 13 2022, 7:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:31 PM
Unknown Object (File)
Sat, Nov 2, 6:21 PM
Unknown Object (File)
Thu, Oct 24, 7:08 PM
Unknown Object (File)
Thu, Oct 24, 11:53 AM

Details

Summary

While working on this stack I've realized there are some incompatible changes we'll need to make (where MariaDB needs one query and MySQL needs another).

To make the transition smooth for devs, and to maintain a potential path to migrate prod back if we see a serious issue after deploying, I'm going to make sure this stack maintains support for both MySQL and MariaDB in the near term.

So the Node application will need to have some awareness of MySQL 5.7 vs. MariaDB 10.8.

Depends on D4515

Test Plan

I added a console.log of dbConfig in loadPool and made sure it included "dbType":"mariadb10.8"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Saw an error:

Ignoring invalid configuration option passed to Connection: dbType. This is currently a warning, but in future versions of MySQL2, an error will be thrown if you pass an invalid configuration option to a Connection

This update removes dbType from dbConfig before passing it to mysql2, and the newly introduced parent diff types things so this doesn't occur again.

This revision is now accepted and ready to land.Jul 14 2022, 9:09 PM

Now that D4499 is at the top of the stack, we'll move the COMM_DATABASE_TYPE=mariadb10.8 declaration to there

This revision was landed with ongoing or failed builds.Jul 17 2022, 8:13 PM
This revision was automatically updated to reflect the committed changes.