Details
Details
Flow; tested in combination with next diffs
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The change makes sense, but explaining the higher level motivation in the Summary section could be helpful
keyserver/src/fetchers/message-fetchers.js | ||
---|---|---|
138 ↗ | (On Diff #14438) | Maybe parsedMessages instead of parseResults, but doesn't really matter |
193–196 ↗ | (On Diff #14438) | My personal preference would be something a little less verbose like: return !rawMessageInfo ? null : { rawMessageInfo, rows: messageRows }; But I know everyone has an opinion on when/where to use ternaries, so feel free to disregard. |