Details

Reviewers

atul
tomek
• jon

Commits

rCOMMb2454cbd5f45: [keyserver] Make rawMessageInfoFromRows return a Promise

Summary

In D4521 we end up needing to await getDBType() in the message-fetchers.js code because we need to parse the query results differently depending on whether it came from MySQL 5.7 or MariaDB 10.8.

Depends on D4518

Test Plan

Flow; tested in combination with next diffs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 13 2022, 4:08 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 4:08 PM

Harbormaster completed remote builds in B10491: Diff 14438.Jul 13 2022, 4:21 PM

ashoat requested review of this revision.Jul 13 2022, 4:21 PM

ashoat added a child revision: D4520: [keyserver] Make mediaFromRow return a Promise.Jul 13 2022, 4:24 PM

Not super qualified to review js, but the intention looks right

The change makes sense, but explaining the higher level motivation in the Summary section could be helpful

keyserver/src/fetchers/message-fetchers.js
138 ↗	(On Diff #14438)	Maybe `parsedMessages` instead of `parseResults`, but doesn't really matter
193–196 ↗	(On Diff #14438)	My personal preference would be something a little less verbose like: return !rawMessageInfo ? null : { rawMessageInfo, rows: messageRows }; But I know everyone has an opinion on when/where to use ternaries, so feel free to disregard.