[keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a Promise
ClosedPublic
Actions

Authored by ashoat on Aug 15 2022, 12:38 PM.

Details

Reviewers

tomek
atul

Commits

rCOMM47dfd97cde84: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a…

Summary

This diff does three things:

Reverts D4519
Reverts D4520
Reverts changes to message-fetchers.js in D4521

I separated this out into its own diff because it has some interlocking parts and I wanted to make sure I did it right / it was reviewed right.

Depends on D4833

Test Plan

Flow
I ran keyserver locally and made sure things generally still worked

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 15 2022, 12:38 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptAug 15 2022, 12:38 PM

ashoat added a child revision: D4835: [keyserver] Get rid of all MySQL-specific query logic.Aug 15 2022, 12:38 PM

Harbormaster completed remote builds in B11357: Diff 15622.Aug 15 2022, 12:49 PM

ashoat requested review of this revision.Aug 15 2022, 12:49 PM

tomek accepted this revision.Aug 16 2022, 5:44 AM

This revision is now accepted and ready to land.Aug 16 2022, 5:44 AM

Closed by commit rCOMM47dfd97cde84: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a… (authored by ashoat). · Explain WhyAug 16 2022, 6:14 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM47dfd97cde84: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

55 lines

upload-fetchers.js

9 lines

Diff 15654

View Options

keyserver/src/fetchers/message-fetchers.js