Page MenuHomePhabricator

[keyserver] Make mediaFromRow return a Promise
ClosedPublic

Authored by ashoat on Jul 13 2022, 9:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:48 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:31 PM
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Sun, Oct 27, 1:59 PM
Unknown Object (File)
Oct 5 2024, 5:14 PM
Unknown Object (File)
Oct 5 2024, 4:59 PM

Details

Summary

In D4521 we end up needing to await getDBType() in the message-fetchers.js code because we need to parse the query results differently depending on whether it came from MySQL 5.7 or MariaDB 10.8.

Depends on D4519

Test Plan

Flow; tested in combination with next diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not super qualified to review js

Same as D4519:

The change makes sense, but explaining the higher level motivation in the Summary section could be helpful

This revision is now accepted and ready to land.Jul 15 2022, 12:46 PM