Page MenuHomePhabricator
Differential D4520

[keyserver] Make mediaFromRow return a Promise
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 9:24 AM.
Tags
None
Referenced Files
F3349918: D4520.diff
Fri, Nov 22, 7:47 PM
Unknown Object (File)
Tue, Nov 19, 9:48 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:31 PM
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Sun, Oct 27, 1:59 PM
Unknown Object (File)
Oct 5 2024, 5:14 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
atul
tomek
• jon
Commits
rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise
Summary

In D4521 we end up needing to await getDBType() in the message-fetchers.js code because we need to parse the query results differently depending on whether it came from MySQL 5.7 or MariaDB 10.8.

Depends on D4519

Test Plan

Flow; tested in combination with next diffs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 13 2022, 9:24 AM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 9:24 AM
Harbormaster completed remote builds in B10492: Diff 14439.Jul 13 2022, 9:34 AM
ashoat requested review of this revision.Jul 13 2022, 9:34 AM
ashoat added a child revision: D4521: [keyserver] Parse JSON columns returned from MariaDB.Jul 13 2022, 10:36 AM
• jon resigned from this revision.Jul 15 2022, 11:09 AM

Not super qualified to review js

atul accepted this revision.Jul 15 2022, 12:46 PM

Same as D4519:

The change makes sense, but explaining the higher level motivation in the Summary section could be helpful

This revision is now accepted and ready to land.Jul 15 2022, 12:46 PM
ashoat edited the summary of this revision. (Show Details)Jul 17 2022, 7:44 AM
Closed by commit rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise (authored by ashoat). · Explain WhyJul 17 2022, 8:13 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMc9c5ad27ff0b: [keyserver] Make mediaFromRow return a Promise.
ashoat added a reverting change: D4834: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a Promise.Aug 15 2022, 12:38 PM
ashoat added a reverting change: rCOMM47dfd97cde84: [keyserver] Move mediaFromRow and rawMessageInfoFromRows back to not return a….Aug 16 2022, 6:14 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
4 lines
4 lines

Diff 14552

View Options

keyserver/src/fetchers/message-fetchers.js

Loading...
View Options

keyserver/src/fetchers/upload-fetchers.js

Loading...