[keyserver] Avoid JSON cast when using MariaDB
ClosedPublic
Actions

Authored by ashoat on Jul 13 2022, 10:49 AM.

Details

Reviewers

• jon
atul
tomek

Commits

rCOMM3133931d2c6a: [keyserver] Avoid JSON cast when using MariaDB

Summary

One difference between MySQL and MariaDB is that MySQL has a JSON column type and MariaDB doesn't.

MySQL requires that the second parameter to JSON_CONTAINS is a JSON type. MariaDB doesn't have JSON types, so it doesn't have this requirement.

We need to make sure we do the cast for MySQL, but not for MariaDB.

Depends on D4521

Test Plan

I ran the web application and clicked around a bunch. Full test plan will come later

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 13 2022, 10:49 AM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 13 2022, 10:49 AM

Harbormaster completed remote builds in B10494: Diff 14441.Jul 13 2022, 11:02 AM

ashoat requested review of this revision.Jul 13 2022, 11:02 AM

• jon added inline comments.Jul 13 2022, 12:03 PM

keyserver/src/fetchers/message-fetchers.js
113 ↗	(On Diff #14441)	Should probably make a follow-up task to the mysql migration to remove the branching logic (which you may already have).

ashoat added a child revision: D4528: [keyserver] Use VALUE instead of VALUES in DUPLICATE KEY UPDATE on MariaDB.Jul 13 2022, 4:27 PM

ashoat added inline comments.Jul 14 2022, 12:27 PM

keyserver/src/fetchers/message-fetchers.js
113 ↗	(On Diff #14441)	Good call!! Done: https://linear.app/comm/issue/ENG-1394/deprecate-mysql-57

atul accepted this revision.Jul 17 2022, 12:53 PM

This revision is now accepted and ready to land.Jul 17 2022, 12:53 PM

Closed by commit rCOMM3133931d2c6a: [keyserver] Avoid JSON cast when using MariaDB (authored by ashoat). · Explain WhyJul 17 2022, 8:13 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM3133931d2c6a: [keyserver] Avoid JSON cast when using MariaDB.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

90 lines

Diff 14553

View Options

keyserver/src/fetchers/message-fetchers.js

[keyserver] Avoid JSON cast when using MariaDBClosedPublicActions