Page MenuHomePhabricator

[keyserver] Switch Docker Compose from MySQL 5.7 to MariaDB 10.8
ClosedPublic

Authored by ashoat on Jul 11 2022, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 6:25 PM
Unknown Object (File)
Tue, Nov 12, 12:12 AM
Unknown Object (File)
Sun, Nov 3, 2:07 PM
Unknown Object (File)
Sat, Nov 2, 6:31 PM
Unknown Object (File)
Sat, Nov 2, 6:21 PM
Unknown Object (File)
Oct 19 2024, 3:16 AM
Unknown Object (File)
Oct 18 2024, 1:49 PM
Unknown Object (File)
Oct 13 2024, 6:11 AM

Details

Summary

This switches our production config. I actually found it easier to start with prod on this one, but updates to the dev environment instructions and Nix config will follow.

Test Plan

I ran the web application and clicked around a bunch. Full test plan will come later

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul added inline comments.
keyserver/docker-compose.yml
19–22 ↗(On Diff #14398)

Should we change MYSQL => MARIADB here as well? Or is that for another diff

27 ↗(On Diff #14398)

Should we use jammy (Ubuntu 22.04 LTS) instead of focal (Ubuntu 20.04 LTS) here?

That'll let us get mariadb up to 10.8.3 instead of 10.7.4

This revision is now accepted and ready to land.Jul 11 2022, 3:57 PM

It's great to see this happening!

keyserver/docker-compose.yml
19–22 ↗(On Diff #14398)

Maybe something more generic, e.g. DATABASE?

keyserver/docker-compose.yml
19–22 ↗(On Diff #14398)

Hmm, so arguably from the perspective of the Node application, it's still connecting to a MySQL server. We're still using the mysql2 npm package to connect.

That said, while working on this I've realized there are some incompatible changes we'll need to make (where MariaDB needs one query and MySQL needs another).

To make the transition smooth for devs, and to maintain a potential path to migrate prod back if we see a serious issue after deploying, I'm going to make sure this stack maintains support for both MySQL and MariaDB in the near term.

So the Node application will need to have some awareness of MySQL 5.7 vs. MariaDB 10.8.

After we deprecate MySQL we can consider changing these variable names. But it's worth noting that MariaDB clients tend to continue calling themselves MySQL clients (eg. mysql and mysqldump CLI).

27 ↗(On Diff #14398)

Good call. My initial reason for going with focal was because we're using Debian bullseye for the Node image. Whereas Ubuntu focal is based on Debian bullseye, Ubuntu jammy is based on Debian bookworm... so my thinking was it's better to keep the same Debian versions across all of the images.

But actually there's not really a super good reason why that matters. And I didn't notice we could use a newer version of MariaDB if we went with jammy.

I'll switch this.

MariaDB 10.8 instead of 10.7

keyserver/docker-compose.yml
19–22 ↗(On Diff #14398)

Rethought the timing here after realizing I'd need to introduce a new environmental variable to clarify MySQL vs. MariaDB. D4515

Rebase so that this is at the top of stack, so I can land the rest without it

Add COMM_DATABASE_TYPE=mariadb10.8 declaration that was previously in D4516

Committed the rest of the stack, but decided to defer this one for a bit. I want to test:

  1. MySQL 5.7 to make sure it still works correctly after these changes
  2. MariaDB 10.8 to make 100% sure that there aren't any extant issues
ashoat retitled this revision from [keyserver] Switch Docker Compose from MySQL 5.7 to MariaDB 10.7 to [keyserver] Switch Docker Compose from MySQL 5.7 to MariaDB 10.8.Jul 18 2022, 8:28 AM

The rest of the stack is now live on prod, which is one way to test and make sure things still work with MySQL 5.7