See comment on Linear. This fixes a bug where we were seeing strings where we previously saw numbers.
Depends on D4528
Details
Details
- Reviewers
• jon atul tomek - Commits
- rCOMMac199c492c82: [keyserver] Cast NULLs in UNION SELECT
- I made sure the syntax was valid on both MySQL 5.7 and MariaDB 10.8 based on docs
- I tested with MariaDB 10.8
- I made sure the issue only occured when merging in NULL in cases where you aren't expecting a string by testing queries
- I git grepd through the codebase to make sure this was the only place we were doing that
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good, testing our DB queries to make sure output is held constant would probably be good to do someday