Page MenuHomePhabricator

[keyserver] Cast NULLs in UNION SELECT
ClosedPublic

Authored by ashoat on Jul 13 2022, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Fri, Oct 18, 4:21 AM
Unknown Object (File)
Mon, Oct 7, 11:44 AM
Unknown Object (File)
Mon, Oct 7, 11:44 AM
Unknown Object (File)
Mon, Oct 7, 11:43 AM
Unknown Object (File)
Mon, Oct 7, 11:40 AM
Unknown Object (File)
Mon, Oct 7, 12:30 AM
Unknown Object (File)
Mon, Oct 7, 12:29 AM

Details

Summary

See comment on Linear. This fixes a bug where we were seeing strings where we previously saw numbers.

Depends on D4528

Test Plan
  1. I made sure the syntax was valid on both MySQL 5.7 and MariaDB 10.8 based on docs
  2. I tested with MariaDB 10.8
  3. I made sure the issue only occured when merging in NULL in cases where you aren't expecting a string by testing queries
  4. I git grepd through the codebase to make sure this was the only place we were doing that

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good, testing our DB queries to make sure output is held constant would probably be good to do someday

This revision is now accepted and ready to land.Jul 14 2022, 9:51 AM
This revision was automatically updated to reflect the committed changes.