[native] Don't use `std::move(...)` in return statements in `Session.cpp`
ClosedPublic
Actions

Authored by atul on Jul 28 2022, 12:52 PM.

Details

Reviewers

ashoat
tomek
• karol

Commits

rCOMM402eb9162381: [native] Don't use `std::move(...)` in return statements in `Session.cpp`

Summary

Caught this with Product -> Analyze when trying to investigate an unrelated issue.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jul 28 2022, 12:52 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptJul 28 2022, 12:52 PM

atul added a reviewer: • karol.Jul 28 2022, 12:52 PM

atul retitled this revision from [native] Don't use `std::move(...)` in return statement in `Session.cpp` to [native] Don't use `std::move(...)` in return statements in `Session.cpp`.Jul 28 2022, 12:57 PM

Harbormaster completed remote builds in B10954: Diff 15072.Jul 28 2022, 1:04 PM

atul requested review of this revision.Jul 28 2022, 1:04 PM

ashoat accepted this revision.Jul 28 2022, 1:59 PM

This revision is now accepted and ready to land.Jul 28 2022, 1:59 PM

Closed by commit rCOMM402eb9162381: [native] Don't use `std::move(...)` in return statements in `Session.cpp` (authored by atul). · Explain WhyJul 29 2022, 8:45 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM402eb9162381: [native] Don't use `std::move(...)` in return statements in `Session.cpp`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

CryptoTools/

Session.cpp

4 lines

Diff 15100

View Options

native/cpp/CommonCpp/CryptoTools/Session.cpp

[native] Don't use `std::move(...)` in return statements in `Session.cpp`ClosedPublicActions