On every push to master we'll remove Harbormaster tags (of the form phabricator/base/123 and phabricator/diff/123) associated with diffs that are "Abandoned"/"Closed".
Depends on D4689
Details
Details
This one is kind of hard to test. Usually test GH Actions workflows on a fork of the repo, but the forked repo didn't hold onto the phabricator tags from CommE2E/comm.
If there are issues, reverting this diff would be simple.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D4690 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
newline end of file
| .github/workflows/remove_harbormaster_tags.yml | ||
|---|---|---|
| 15 ↗ | (On Diff #15130) | This isn't great, but works for the time being. Will add gaxios to the "root" package.json in a subsequent diff (it currently exists in native/package.json) |
Comment Actions
I don't make sense as a first-pass reviewer here. Please see list of reasons to add me as a first-pass reviewer here
Comment Actions
That's fair.
I thought it made sense to add you to https://phab.comm.dev/D4689 since it's applying changes directly to the repo... and then this diff shows how the script in D4689 is consumed so I thought it made sense to add you here as well.
Comment Actions
This makes sense in conjunction with D4689, but I had some questions regarding that diff so will hold off on accepting this until that diff is accepted in case this one changes (I don't think it should, though, since my questions were only about the contents of the script, not its directory, etc.).