Paths

Table of Contentst

-
lib/shared/
-
shared/
-
relationship-utils.js
-
native/chat/settings/
-
chat/
-
settings/
-
thread-settings-edit-relationship.react.js

[lib] Introduce shared `getRelationshipDispatchAction` function
ClosedPublic
Actions

Authored by • jacek on Jul 29 2022, 2:59 AM.

Details

Reviewers

tomek
atul

Commits

rCOMMe062e9755868: [lib] Introduce shared `getRelationshipDispatchAction` function

Summary

Move part of the logic responsible for selecting correct RelationshipAction basing on provided RelationshipButton to lib so it could be resused on web

Test Plan

Confirm the existing logic still worrks on native

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Jul 29 2022, 2:59 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 29 2022, 2:59 AM

Harbormaster completed remote builds in B10966: Diff 15088.Jul 29 2022, 3:11 AM

• jacek requested review of this revision.Jul 29 2022, 3:11 AM

• jacek added a child revision: D4679: [web] Introduce `ThreadSettingsRelationshipButton` component.Jul 29 2022, 3:27 AM

tomek accepted this revision.Jul 29 2022, 5:24 AM

tomek added inline comments.

lib/shared/relationship-utils.js
11–12 ↗	(On Diff #15088)	Can we merge these two imports? Both use the same source.

This revision is now accepted and ready to land.Jul 29 2022, 5:24 AM

Fix imports

Harbormaster completed remote builds in B11041: Diff 15184.Aug 2 2022, 2:25 AM

Closed by commit rCOMMe062e9755868: [lib] Introduce shared `getRelationshipDispatchAction` function (authored by • jacek). · Explain WhyAug 3 2022, 4:27 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMMe062e9755868: [lib] Introduce shared `getRelationshipDispatchAction` function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

relationship-utils.js

27 lines

native/

chat/

settings/

thread-settings-edit-relationship.react.js

25 lines

Diff 15184

View Options

lib/shared/relationship-utils.js

	#include "CryptoModule.h"			#include "CryptoModule.h"
	#include "PlatformSpecificTools.h"			#include "PlatformSpecificTools.h"
	#include "olm/session.hh"			#include "olm/session.hh"

				#include <stdexcept>

	namespace comm {			namespace comm {
	namespace crypto {			namespace crypto {

	CryptoModule::CryptoModule(std::string id) : id{id} {			CryptoModule::CryptoModule(std::string id) : id{id} {
	this->createAccount();			this->createAccount();
	}			}

	CryptoModule::CryptoModule(			CryptoModule::CryptoModule(
	▲ Show 20 Lines • Show All 292 Lines • Show Last 20 Lines