[keyserver] Clean up `scp-backup.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 9:03 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMM6485a52417fc: [keyserver] Clean up `scp-backup.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck

Additionally, this script is run during the keyserver build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 2 2022, 9:03 AM

Herald added a subscriber: • adrian. · View Herald TranscriptAug 2 2022, 9:03 AM

• abosh added inline comments.Aug 2 2022, 9:04 AM

keyserver/bash/scp-backup.sh
17	Double quote to prevent globbing and word splitting.

Harbormaster completed remote builds in B11055: Diff 15217.Aug 2 2022, 9:16 AM

• abosh requested review of this revision.Aug 2 2022, 9:16 AM

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 9:22 AM

• abosh edited the summary of this revision. (Show Details)Aug 2 2022, 9:32 AM

Feel like there's probably a cleaner way to determine NEWEST_BACKUP, but this resolves the relevant shellcheck issue.

This revision is now accepted and ready to land.Aug 2 2022, 10:30 AM

In D4713#135601, @atul wrote:

Feel like there's probably a cleaner way to determine NEWEST_BACKUP, but this resolves the relevant shellcheck issue.

I concur! But since I wanted to appease ShellCheck I didn't think too hard about re-organizing the quotes since it can get messy.

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 10:44 AM

Tested this in prod and it works

Closed by commit rCOMM6485a52417fc: [keyserver] Clean up `scp-backup.sh` using ShellCheck (authored by • abosh). · Explain WhyAug 2 2022, 2:18 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM6485a52417fc: [keyserver] Clean up `scp-backup.sh` using ShellCheck.