[keyserver] Clean up `source-nvm.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 9:18 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMMb02560464e49: [keyserver] Clean up `source-nvm.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck

Additionally, this script is run during the keyserver build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 2 2022, 9:18 AM

Herald added a subscriber: • adrian. · View Herald TranscriptAug 2 2022, 9:18 AM

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 9:22 AM

• abosh added inline comments.

keyserver/bash/source-nvm.sh
12–19	Can't follow non-constant source. Use a directive to specify location.

Harbormaster completed remote builds in B11057: Diff 15219.Aug 2 2022, 9:30 AM

• abosh requested review of this revision.Aug 2 2022, 9:30 AM

• abosh added inline comments.Aug 2 2022, 9:37 AM

keyserver/bash/source-nvm.sh
12–13	Not following: /usr/local/opt/nvm/nvm.sh was not specified as input (see shellcheck -x).
12–19	This comment should only apply to lines 18-19.
15–16	Not following: /opt/homebrew/opt/nvm/nvm.sh was not specified as input (see shellcheck -x).