[services] Tunnelbroker - Remove `ToDeviceID` index from messages table
ClosedPublic
Actions

Authored by • max on Aug 1 2022, 7:05 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMM87ae93613c5d: [services] Tunnelbroker - Remove `ToDeviceID` index from messages table

Summary

Because we've switched to the composite key in the messages table we don't need an additional index for a toDeviceID. We can use a hash_key.

Linear task: ENG-1493

Test Plan

Run yarn init-local-cloud is expected to be successful.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Aug 1 2022, 7:05 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 1 2022, 7:05 AM

• max published this revision for review.Aug 1 2022, 7:07 AM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • karol, tomek.

• max added parent revisions: D4694: [services] Tunnelbroker - Change `findMessageItem`, `removeMessageItem` to use composite key, D4693: [services] Tunnelbroker - Fix `IDs` in Terraform dynamodb table attributes.

• max added a child revision: D4696: [services] Tunnelbroker - Fix table names to use config-only instead of constant.Aug 1 2022, 7:17 AM

Harbormaster completed remote builds in B11002: Diff 15136.Aug 1 2022, 7:17 AM

tomek accepted this revision.Aug 2 2022, 8:59 AM

This revision is now accepted and ready to land.Aug 2 2022, 8:59 AM

How do we keep this in sync with AWS cloud? Is the cloud recreated using the scripts or we do this by hand?

In D4695#135452, @tomek wrote:

How do we keep this in sync with AWS cloud? Is the cloud recreated using the scripts or we do this by hand?

We are doing this by hand in AWS and by yarn init-local-cloud to update the localstack.

Rebase and merge on master changes.

Harbormaster completed remote builds in B11059: Diff 15222.Aug 2 2022, 9:48 AM

Closed by commit rCOMM87ae93613c5d: [services] Tunnelbroker - Remove `ToDeviceID` index from messages table (authored by • max). · Explain WhyAug 2 2022, 10:18 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM87ae93613c5d: [services] Tunnelbroker - Remove `ToDeviceID` index from messages table.

@max, is there a task tracking configuring Tunnelbroker in AWS via Terraform? If not, can you create one?

In D4695#135636, @ashoat wrote:

@max, is there a task tracking configuring Tunnelbroker in AWS via Terraform? If not, can you create one?

I think it's tracked for all services by ENG-1057

Can you create a new one specific to Tunnelbroker, assign it to yourself, add it as a related task to ENG-1057, and slot it in for Tunnelbroker 0.5?

In D4695#135515, @max wrote:

In D4695#135452, @tomek wrote:

How do we keep this in sync with AWS cloud? Is the cloud recreated using the scripts or we do this by hand?

We are doing this by hand in AWS and by yarn init-local-cloud to update the localstack.