Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.
Details
Details
Similarly as in D4724, I went to @karol's diff D4580 where this code was introduced. Looks like @karol noted:
the desired behavior for them is to fail with a message "unimplemented".
So I'm assuming this was supposed to break, and that is why it is still failing? I don't have much context on this. Either way, this diff is scoped to the ShellCheck side of the script, so if it's supposed to fail/be broken then I think that's outside the scope of this diff.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
bash-wise, this looks correct. But I would wait for @karol 's response before moving forward.
Comment Actions
It would be more readable if you wrapped the diffs into a stack.
Diff looks ok.
Performance tests are unimplemented for tunnelbroker, they work well for blob and they're blocked for backup (don't work).
Comment Actions
It would be more readable if you wrapped the diffs into a stack.
I agree! Although since the code for a lot of these diffs technically doesn't really depend on each other, I wasn't sure if to make a depends on. But I guess next time I will, since some of these diffs are closely related.
Performance tests are unimplemented for tunnelbroker, they work well for blob and they're blocked for backup (don't work).
Got it.
Comment Actions
I agree! Although since the code for a lot of these diffs technically doesn't really depend on each other, I wasn't sure if to make a depends on.
Personally, I treat dependenices on Phabricator as a storytelling tool more than a way to actually indicate formal dependency relationships. Another way to think about it... a diff is a commit, and a stack is a branch.