[CI] Remove “Install `ShellCheck`” step from `ShellCheck` GitHub Actions workflow
ClosedPublic
Actions

Authored by • abosh on Aug 5 2022, 12:04 PM.

Details

Reviewers

atul

Commits

rCOMMfd643eb1899a: [CI] Remove “Install `ShellCheck`” step from `ShellCheck` GitHub Actions…

Summary

Because ShellCheck comes pre-installed on the GitHub Actions virtual environment we're using for this workflow (ubuntu-latest), we don't need to include the installation commands for ShellCheck.

Read more on the GitHub Actions Virtual Environments README for ubuntu-latest, under the “Installed apt packages” section.

Test Plan

Land this diff and see if the workflow executes as expected on GitHub.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 5 2022, 12:04 PM

Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptAug 5 2022, 12:04 PM

• abosh edited the summary of this revision. (Show Details)Aug 5 2022, 12:07 PM

• abosh edited the test plan for this revision. (Show Details)

• abosh edited the summary of this revision. (Show Details)

• abosh retitled this revision from [CI] Remove “Install ShellCheck” step from `ShellCheck` GitHub Actions workflow to [CI] Remove “Install `ShellCheck`” step from `ShellCheck` GitHub Actions workflow.

Harbormaster completed remote builds in B11170: Diff 15376.Aug 5 2022, 12:16 PM

• abosh requested review of this revision.Aug 5 2022, 12:16 PM

atul accepted this revision.Aug 5 2022, 1:29 PM

This revision is now accepted and ready to land.Aug 5 2022, 1:29 PM

Closed by commit rCOMMfd643eb1899a: [CI] Remove “Install `ShellCheck`” step from `ShellCheck` GitHub Actions… (authored by • abosh). · Explain WhyAug 5 2022, 2:55 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMfd643eb1899a: [CI] Remove “Install `ShellCheck`” step from `ShellCheck` GitHub Actions….

• abosh mentioned this in D4819: [Chore] Make shellcheck happy.Aug 12 2022, 8:17 AM

• abosh mentioned this in D4828: [CI] Add “Install ShellCheck” step to ShellCheck GitHub Actions workflow.Aug 12 2022, 8:42 AM

• abosh mentioned this in rCOMMd42b19f446a5: [CI] Add “Install ShellCheck” step to ShellCheck GitHub Actions workflow.Aug 12 2022, 8:47 AM