Differential D4822
[Nix] Add m1 bash default prompt to list Authored by • jon on Aug 11 2022, 10:56 PM. Tags None Referenced Files
Details Context: https://linear.app/comm/issue/ENG-1550#comment-f6df3682 Add Ashoat's default PS1, which seems to be the default for some m1 mac's. Used my wife's m1 mac computer to see what her unadulterated ps1 was (she doesn't program), my intel mac, and my linux box to determine the 2 PS1's fro https://phab.comm.dev/D4790. But I guess MacOS has many different defaults depending on something I'm not sure of. # Ensure that ~/.bashrc won't affect logic
# Should only be necessary if personally configured
[[ -f ~/.bashrc ]] && mv ~/.bashrc ~/.bashrc.bak
# from any branch
nix develop 'github.com:commE2E/comm?ref=jonringer/ashoat-ps1'
# Prompt should look decent
# restore old bashrc
[[ -f ~/.bashrc.bak ]] && mv ~/.bashrc{.bak,}Same test plan for https://phab.comm.dev/D4790
Diff Detail
Event TimelineComment Actions Not sure what you mean by "Ashoat's default PS1". This is what I set in my ~/.bash_profile: PS1="\u@\h [\w]$ " Can you clarify more?
Comment Actions
Oh, if you set it, isn't that the prompt which you wanted to use? I thought the goal was, "if someone has an opinionated prompt, just let them use it, but if they don't then give them much nicer one." Setting the prompt to be something different communicates to me that is the intended way you want to use the shell. Who am I to overwrite your wishes?
I nuked my ~/.bash{_profile,rc} with my own stuff which I'm familiar with, check my wife's mac to get the values I have populated there. I was under the impression that the PS1 you have right now was inherited. I'll abandon this.
It's a developer shell, some developers may already have a bash workflow they grok already. I don't think we should be unilaterally deciding what prompt they should be using. Just provide a better default.
That was my intention. Especially on macos where it's pretty likely that people don't even try configuring bash, as zsh has been the default for a while now. Comment Actions The original linear text was:
I guess I meant that to mean, "provide a better default" Comment Actions I'm not sure you realized that the PS1 I quoted from my ~/.bash_profile above is not the one that is being used by Nix, and not the one you've added here
Makes sense as an answer to 2, but I still need an answer to 1:
Comment Actions
Are you talking about what is there already? I got those from removing my ~/.bashrc and examining what was there. '\s-\v\$' was on my wife's m1 machine and my intel mac, %n@%m %1~ %# is what my linux produced, and looks like my m1 is also producing '\h:\W \u\$ ' Comment Actions [10:07:47] jon@Jonathans-Mac-mini ~ $ mv ~/.bashrc ~/.bashrc.bak # new terminal session Jonathans-Mac-mini:~ jon$ echo "'$PS1'" '\h:\W \u\$ ' Comment Actions I think @ashoat may have hit Request Changes after submitting his comment but not before you replied here, which is why this diff is in a weird state of you answered his question but received no response and instead got a request for revision. I also share some of @ashoat's confusion as to where \h:\W \u\$ came from. After pasting it into this prompt generator, this is what I see:   So I have a visual understanding of what the prompt looks like, but because I don't really use bash on my Mac, I don't know if this is the default or not. @ashoat does use bash on Mac, but he has an opinionated PS1 (\u@\h [\w]$ ), so he probably didn't immediately recognize the default, either. Hence why he asked where \h:\W \u\$ came from.
This is true for me. I hardly touch bash on my M1 machine, and wasn't really familiar with the default bash prompt for MacOS since I use zsh. I think your latest comment showing terminal output is enough to convince me that \h:\W \u\$ is a default for bash on MacOS, and should be added as a prompt that we should check for to make sure the user has a different PS1. But next time, please provide some of this clarifying information in the diff summary or test plan. Like any sort of concrete evidence to show that \h:\W \u\$ is the default (command line output, pictures, etc.). The diff should be small, but the summary and test plan should be descriptive. Comment Actions
This is a continuation of D4790, where I only captured 2 potential defaults, \h:\W \u\$ is a third.
Fair enough, it was in response to https://linear.app/comm/issue/ENG-1550#comment-f6df3682 where @ashoat mentioned that powerline wasn't being triggered. Although it was being triggered on my intel mac. |