Page MenuHomePhabricator
Differential D4832

[keyserver] Introduce assertValidDBType
ClosedPublic
Actions

Authored by ashoat on Aug 15 2022, 12:37 PM.
Tags
None
Referenced Files
F3351663: D4832.diff
Sat, Nov 23, 3:03 AM
Unknown Object (File)
Fri, Nov 15, 10:29 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:32 PM
Unknown Object (File)
Sat, Nov 2, 6:31 PM
Unknown Object (File)
Sat, Nov 2, 6:21 PM
Unknown Object (File)
Fri, Oct 25, 7:28 PM
Unknown Object (File)
Oct 7 2024, 9:37 AM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
tomek
atul
Commits
rCOMM3b928cdd35d8: [keyserver] Introduce assertValidDBType
Summary

This diff is a simple refactor, and should be a no-op. In the next diff I'll modify assertValidDBType to deprecate MySQL.

Test Plan
  1. Flow
  2. I ran keyserver locally and made sure things generally still worked

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Aug 15 2022, 12:37 PM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptAug 15 2022, 12:37 PM
ashoat added a child revision: D4833: [keyserver] Deprecate MySQL support.Aug 15 2022, 12:38 PM
Harbormaster completed remote builds in B11355: Diff 15620.Aug 15 2022, 12:47 PM
ashoat requested review of this revision.Aug 15 2022, 12:47 PM
tomek accepted this revision.Aug 16 2022, 5:34 AM
This revision is now accepted and ready to land.Aug 16 2022, 5:34 AM
ashoat added a comment.Aug 16 2022, 6:12 AM

(Technically this isn't a pure refactor... if anybody had a bad DBType (neither 'mariadb10.8' nor 'mysql5.7') in their DB config previously, it previously would've defaulted to 'mysql5.7', but now will error. I think this is a good thing.)

Closed by commit rCOMM3b928cdd35d8: [keyserver] Introduce assertValidDBType (authored by ashoat). · Explain WhyAug 16 2022, 6:14 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM3b928cdd35d8: [keyserver] Introduce assertValidDBType.

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
19 lines

Diff 15620

View Options

keyserver/src/database/db-config.js

Loading...