Page MenuHomePhabricator
Differential D4833

[keyserver] Deprecate MySQL support
ClosedPublic
Actions

Authored by ashoat on Aug 15 2022, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 8:14 AM
Unknown Object (File)
Tue, Apr 22, 2:43 AM
Unknown Object (File)
Mon, Apr 21, 10:38 PM
Unknown Object (File)
Mon, Apr 21, 2:38 AM
Unknown Object (File)
Sun, Apr 6, 6:18 AM
Unknown Object (File)
Mar 16 2025, 10:04 AM
Unknown Object (File)
Mar 16 2025, 8:44 AM
Unknown Object (File)
Mar 13 2025, 2:45 PM
View All Files
Subscribers
• abosh
• adrian

Details

Reviewers
tomek
atul
Commits
rCOMM3b1ce52af279: [keyserver] Deprecate MySQL support
Summary

This diff causes the app to crash if dbType is missing (as it previously defaulted to 'mysql5.7'), or if it is present and set to 'mysql5.7'.

Depends on D4832

Test Plan
  1. Flow
  2. I ran keyserver locally and made sure things generally still worked

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
19 lines

Diff 15621

View Options

keyserver/src/database/db-config.js

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesfunction ConnectFarcaster(prop: Props): React.Node {
const [webViewState, setWebViewState] = const [webViewState, setWebViewState] =
React.useState<FarcasterWebViewState>('closed'); React.useState<FarcasterWebViewState>('closed');
const { ethereumAccount } = cachedSelections; const { ethereumAccount } = cachedSelections;
const goToNextStep = React.useCallback( const goToNextStep = React.useCallback(
(fid?: ?string) => { (fid?: ?string) => {
setWebViewState('closed'); setWebViewState('closed');
invariant(
!ethereumAccount || ethereumAccount.nonceTimestamp,
'nonceTimestamp must be set after connecting to ethereum account',
);
const nonceExpired = const nonceExpired =
ethereumAccount && siweNonceExpired(ethereumAccount.nonceTimestamp); ethereumAccount &&
ethereumAccount.nonceTimestamp &&
siweNonceExpired(ethereumAccount.nonceTimestamp);
if (nonceExpired) { if (nonceExpired) {
setCachedSelections(oldUserSelections => ({ setCachedSelections(oldUserSelections => ({
...oldUserSelections, ...oldUserSelections,
ethereumAccount: undefined, ethereumAccount: undefined,
})); }));
} }
if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) { if (!skipEthereumLoginOnce || !ethereumAccount || nonceExpired) {
▲ Show 20 Lines • Show All 180 Lines • Show Last 20 Lines