Paths

Table of Contentst

[native] Replace `reply-filled` icon in `SwipeableMessage` with `CommIcon`
ClosedPublic
Actions

Authored by atul on Aug 16 2022, 10:45 AM.

Details

Reviewers

• jacek
tomek
• abosh
varun

Commits

rCOMM959d3d602495: [native] Replace `reply-filled` icon in `SwipeableMessage` with `CommIcon`

Summary

Searched through codebase for usages of the reply-filled icon and found one instance in the SwipeableMessage component.

Swapped out the SWMansionIcon component for the CommIcon component.

NOTE: Going to create individual diffs for all usages of each icon for CommIcons to make the before/after clear. There are only 6 custom CommIcons so this shouldn't produce too much spam.

On the other hand going to do all of hte SWMansion icon changes together in one go.

Test Plan

Before:

Simulator Screen Shot - iPhone 12 - 2022-08-16 at 14.01.17.png (2×1 px, 331 KB)

After:

Simulator Screen Shot - iPhone 12 - 2022-08-16 at 14.02.00.png (2×1 px, 330 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Aug 16 2022, 10:45 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 16 2022, 10:45 AM

Harbormaster completed remote builds in B11389: Diff 15668.Aug 16 2022, 10:55 AM

atul requested review of this revision.Aug 16 2022, 10:55 AM

atul edited the test plan for this revision. (Show Details)Aug 16 2022, 10:59 AM

atul edited the test plan for this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)Aug 16 2022, 11:02 AM

atul edited the summary of this revision. (Show Details)Aug 16 2022, 11:05 AM

• abosh edited the summary of this revision. (Show Details)Aug 16 2022, 11:07 AM

atul edited the summary of this revision. (Show Details)Aug 16 2022, 11:07 AM

• abosh edited the summary of this revision. (Show Details)Aug 16 2022, 11:08 AM

• abosh edited the summary of this revision. (Show Details)

varun accepted this revision.Aug 16 2022, 11:10 AM

This revision is now accepted and ready to land.Aug 16 2022, 11:10 AM

rebase around un-accepted diffs to land

Harbormaster completed remote builds in B11392: Diff 15671.Aug 16 2022, 11:33 AM

Closed by commit rCOMM959d3d602495: [native] Replace `reply-filled` icon in `SwipeableMessage` with `CommIcon` (authored by atul). · Explain WhyAug 16 2022, 11:41 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM959d3d602495: [native] Replace `reply-filled` icon in `SwipeableMessage` with `CommIcon`.

Revision Contents
Changeset List

Path

Size

native/

chat/

swipeable-message.react.js

3 lines

Diff 15672

View Options

native/chat/swipeable-message.react.js

[native] Replace `reply-filled` icon in `SwipeableMessage` with `CommIcon`ClosedPublicActions