Page MenuHomePhabricator

[native] Replace `cloud-filled` icon in `CommunityPill` with `CommIcon`
ClosedPublic

Authored by atul on Aug 15 2022, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:54 PM
Unknown Object (File)
Thu, Nov 7, 3:58 AM
Unknown Object (File)
Tue, Nov 5, 2:06 AM
Unknown Object (File)
Tue, Oct 22, 5:45 AM
Unknown Object (File)
Oct 6 2024, 2:37 AM
Subscribers

Details

Summary

Searched through codebase for usages of the cloud-filled icon and found one instance in the CommunityPill component.

Swapped out the SWMansionIcon component for the CommIcon component.

Why did the size change?

I believe it's because there was additional space/padding around the previous cloud-filled icon that made it appear smaller than it actually was. Will double check this once I get to re-creating the SWMansionIcon pack with all of the provided icons and without the custom Comm ones.

NOTE: Going to create individual diffs for all usages of each icon for CommIcons to make the before/after clear. There are only 6 custom CommIcons so this shouldn't produce too much spam.

On the other hand going to do all of the SWMansion icons together in one go.

Test Plan

Before:

Simulator Screen Shot - iPhone 12 - 2022-08-15 at 16.01.05.png (2×1 px, 193 KB)

After:

Simulator Screen Shot - iPhone 12 - 2022-08-15 at 16.22.53.png (2×1 px, 193 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul edited the summary of this revision. (Show Details)
atul requested review of this revision.Aug 15 2022, 1:45 PM
This revision is now accepted and ready to land.Aug 15 2022, 1:53 PM
This revision now requires review to proceed.Aug 16 2022, 7:02 AM
This revision is now accepted and ready to land.Aug 16 2022, 11:24 AM