Page MenuHomePhabricator
Differential D4840

[native] Replace `sidebar-filled` icon in `SwipeableMessage` with `CommIcon`
ClosedPublic
Actions

Authored by atul on Aug 15 2022, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:57 PM
Unknown Object (File)
Fri, Nov 8, 8:54 PM
Unknown Object (File)
Tue, Nov 5, 2:06 AM
Unknown Object (File)
Thu, Oct 24, 12:19 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• abosh
varun
Commits
rCOMMcbc35ec0c5c7: [native] Replace `sidebar-filled` icon in `SwipeableMessage` with `CommIcon`
Summary

Searched through codebase for usages of the sidebar-filled icon and found one instance in the SwipeableMessage component.

Swapped out the SWMansionIcon component for the CommIcon component.

NOTE: Going to create individual diffs for all usages of each icon for CommIcons to make the before/after clear. There are only 6 custom CommIcons so this shouldn't produce too much spam.

On the other hand going to do all of the SWMansion icons together in one go.

Test Plan

Before:

Screen Shot 2022-08-15 at 4.35.39 PM.png (1×744 px, 396 KB)

After:

Screen Shot 2022-08-15 at 4.35.39 PM.png (1×744 px, 396 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Aug 15 2022, 1:38 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 15 2022, 1:38 PM
Harbormaster completed remote builds in B11364: Diff 15629.Aug 15 2022, 1:48 PM
atul requested review of this revision.Aug 15 2022, 1:48 PM
atul updated this revision to Diff 15630.Aug 15 2022, 1:51 PM

newlines

• abosh requested changes to this revision.Aug 15 2022, 1:58 PM

Visually, does this change look the same? Can you add before/after pictures like you did in D4839?

This revision now requires changes to proceed.Aug 15 2022, 1:58 PM
Harbormaster completed remote builds in B11365: Diff 15630.Aug 15 2022, 1:58 PM
atul added a comment.Aug 16 2022, 8:14 AM
In D4840#139893, @abosh wrote:

Visually, does this change look the same? Can you add before/after pictures like you did in D4839?

Yeah sorry, thought I'd filled those out. Updating the summary momentarily

atul requested review of this revision.Aug 16 2022, 8:14 AM
atul edited the test plan for this revision. (Show Details)
• abosh accepted this revision.Aug 16 2022, 8:32 AM

Ok, looks good!

This revision is now accepted and ready to land.Aug 16 2022, 8:32 AM
atul added 2 blocking reviewer(s): tomek, varun.Aug 16 2022, 8:32 AM
This revision now requires review to proceed.Aug 16 2022, 8:32 AM
atul edited the summary of this revision. (Show Details)Aug 16 2022, 11:05 AM
atul removed 1 blocking reviewer(s): tomek.Aug 16 2022, 11:11 AM
varun accepted this revision.Aug 16 2022, 11:25 AM
This revision is now accepted and ready to land.Aug 16 2022, 11:25 AM
atul updated this revision to Diff 15674.Aug 16 2022, 11:52 AM

rebase before landing

atul updated this revision to Diff 15675.Aug 16 2022, 11:53 AM

cut extraneous import

Harbormaster completed remote builds in B11394: Diff 15674.Aug 16 2022, 12:02 PM
Harbormaster completed remote builds in B11395: Diff 15675.
Closed by commit rCOMMcbc35ec0c5c7: [native] Replace `sidebar-filled` icon in `SwipeableMessage` with `CommIcon` (authored by atul). · Explain WhyAug 16 2022, 12:11 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMcbc35ec0c5c7: [native] Replace `sidebar-filled` icon in `SwipeableMessage` with `CommIcon`.

Revision Contents
Changeset List

PathSize
native/
chat/
5 lines

Diff 15677

View Options

native/chat/swipeable-message.react.js

Loading...