Page MenuHomePhabricator

[web] Introduce `CommIcon` component
ClosedPublic

Authored by atul on Aug 16 2022, 12:56 PM.
Tags
None
Referenced Files
F3369144: D4850.diff
Mon, Nov 25, 10:00 PM
Unknown Object (File)
Tue, Nov 12, 12:22 PM
Unknown Object (File)
Fri, Nov 8, 6:43 PM
Unknown Object (File)
Sun, Nov 3, 7:26 PM
Unknown Object (File)
Oct 6 2024, 3:09 AM
Unknown Object (File)
Oct 6 2024, 3:09 AM
Unknown Object (File)
Oct 6 2024, 3:08 AM
Unknown Object (File)
Oct 6 2024, 3:06 AM
Subscribers

Details

Summary

Use the same lib/shared/comm-icon-config.json (exported from IcoMoon) as we're using for CommIcon on native. This ensures that CommIcon on native and web are synced up. Before the icons from IcoMoon were exported separately on native and web which led to some inconsistency.

Heavily inspired by the SWMansionIcon.react.js component in the same directory.

Test Plan

Was able to consume CommIcon component as expected. Tested implicitly by subsequent diffs that replace some usages of SWMansionIcon with CommIcon.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage