[web] Replace `cloud-filled` icon in `ChatThreadAncestors` with `CommIcon`
ClosedPublic
Actions

Authored by atul on Aug 16 2022, 1:02 PM.

Details

Reviewers

• jacek
tomek
• abosh
varun

Commits

rCOMM05edd68356d6: [web] Replace `cloud-filled` icon in `ChatThreadAncestors` with `CommIcon`

Summary

Searched through codebase for usages of cloud-filled and found one instance in the ChatThreadAncestors component.

Swapped out the SWMansionIcon component for the CommIcon component.

NOTE: Going to create individual diffs for all usages of each icon for CommIcons to make the before/after clear. There are only 6 custom CommIcons so this shouldn't produce too much spam.

Test Plan

WARNING: The actual icon changed. I'm using the same cloud icon we decided with Alicja to go with on native. I strongly think we should go with the same filled cloud icon on web because A. consistency B. it looks a lot better than an open path.

Before:

After:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 16 2022, 1:02 PM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 16 2022, 1:02 PM

atul edited the test plan for this revision. (Show Details)Aug 16 2022, 1:03 PM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B11399: Diff 15681.Aug 16 2022, 1:12 PM

atul requested review of this revision.Aug 16 2022, 1:12 PM

WARNING: The actual icon changed. I'm using the same cloud icon we decided with Alicja to go with on native. I strongly think we should go with the same filled cloud icon on web because A. consistency B. it looks a lot better than an open path.

Thanks for noting this. I agree.

This revision is now accepted and ready to land.Aug 16 2022, 1:32 PM

varun accepted this revision.Aug 16 2022, 1:39 PM

Closed by commit rCOMM05edd68356d6: [web] Replace `cloud-filled` icon in `ChatThreadAncestors` with `CommIcon` (authored by atul). · Explain WhyAug 16 2022, 1:59 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM05edd68356d6: [web] Replace `cloud-filled` icon in `ChatThreadAncestors` with `CommIcon`.