Use `==` in string equality check in `detect_abis.sh`
ClosedPublic
Actions

Authored by • abosh on Aug 16 2022, 6:18 PM.

Details

Reviewers

atul
• jon

Commits

rCOMM42e38d9502a4: Use `==` in string equality check in `detect_abis.sh`

Summary

Noticed this after landing D4851.

Test Plan

Ran yarn react-native run-android in native directory again, built successfully.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 16 2022, 6:18 PM

Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptAug 16 2022, 6:18 PM

Harbormaster completed remote builds in B11406: Diff 15695.Aug 16 2022, 6:28 PM

• abosh requested review of this revision.Aug 16 2022, 6:28 PM

= is the same as == in any shell that supports [[...]]

This revision is now accepted and ready to land.Aug 16 2022, 7:06 PM

In D4853#140513, @jon wrote:

= is the same as == in any shell that supports [[...]]

True (which is why the original code worked)! But I think stylistically == is better than = for equality, because = feels like assignment, especially to someone not familiar with bash.

Closed by commit rCOMM42e38d9502a4: Use `==` in string equality check in `detect_abis.sh` (authored by • abosh). · Explain WhyAug 17 2022, 7:38 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM42e38d9502a4: Use `==` in string equality check in `detect_abis.sh`.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

bash/

detect_abis.sh

2 lines

Diff 15695

View Options

native/android/app/bash/detect_abis.sh

Use `==` in string equality check in `detect_abis.sh`ClosedPublicActions