Paths

Table of Contentst

[native] Use `Array.some(...)` in `uploadInProgress`
ClosedPublic
Actions

Authored by • abosh on Aug 19 2022, 2:13 PM.

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM7f7f5ebfdd11: [native] Use `Array.some(...)` in `uploadInProgress`

Summary

Depends on D4890. Minor change that avoids another level of indentation/for loop by using Array.some(...).

Test Plan

Flow, close reading.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 19 2022, 2:13 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 19 2022, 2:13 PM

Harbormaster completed remote builds in B11486: Diff 15798.Aug 19 2022, 2:21 PM

• abosh requested review of this revision.Aug 19 2022, 2:21 PM

tomek accepted this revision.Aug 25 2022, 2:26 AM

tomek added inline comments.

native/input/input-state-container.react.js
376–378	Using `Object.values` might simplify it even further

This revision is now accepted and ready to land.Aug 25 2022, 2:26 AM

• abosh marked an inline comment as done.Aug 25 2022, 8:01 AM

• abosh added inline comments.

native/input/input-state-container.react.js
376–378	Unfortunately Flow complains, but it is much cleaner!

• abosh attached a referenced file: F149480: image.png. (Show Details)Aug 25 2022, 8:01 AM

• abosh added a child revision: D4955: [native] Make return value more concise in `uploadInProgress`.Aug 25 2022, 10:52 AM

ashoat added inline comments.Aug 26 2022, 11:25 AM

native/input/input-state-container.react.js
376–378	You can use `values` in `lib/utils/objects.js`

Closed by commit rCOMM7f7f5ebfdd11: [native] Use `Array.some(...)` in `uploadInProgress` (authored by • abosh). · Explain WhyAug 26 2022, 12:29 PM

This revision was automatically updated to reflect the committed changes.

• abosh marked an inline comment as done.

• abosh added a commit: rCOMM7f7f5ebfdd11: [native] Use `Array.some(...)` in `uploadInProgress`.

• abosh mentioned this in D4961: [native] Use `values(...)` in `InputStateContainer`.Aug 26 2022, 1:41 PM

• abosh mentioned this in rCOMM08dfbbfd79e7: [native] Use `values(...)` in `InputStateContainer`.Aug 29 2022, 10:17 AM

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

11 lines

Diff 15798

View Options

native/input/input-state-container.react.js

[native] Use `Array.some(...)` in `uploadInProgress`ClosedPublicActions